Skip to content

NO TICKET: m to ft fix#313

Merged
chasetmartin merged 2 commits into
stagingfrom
ft-to-m-fix
Dec 18, 2025
Merged

NO TICKET: m to ft fix#313
chasetmartin merged 2 commits into
stagingfrom
ft-to-m-fix

Conversation

@jacob-a-brown

Copy link
Copy Markdown
Contributor

Why

This PR addresses the following problem / context:

  • There were duplicate functions to convert from meters to feet
  • The number of digits in the rounding was hardcoded. It is now an argument in the function and defaults to 6, which is what was used previously
  • util functions need to be tested

How

Implementation summary - the following was changed / added / removed:

  • Removed one of the duplicate functions
  • Enabled the number of digits in the round function to be set as an argument
  • Started a test file for services/util.py and added tests for convert_ft_to_m and convert_m_to_ft

Notes

Any special considerations, workarounds, or follow-up work to note?

  • Use bullet points here

@codecov-commenter

codecov-commenter commented Dec 17, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Files with missing lines Coverage Δ
services/util.py 67.61% <100.00%> (+6.15%) ⬆️
tests/test_util.py 100.00% <100.00%> (ø)

@chasetmartin chasetmartin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chasetmartin chasetmartin merged commit b5adf60 into staging Dec 18, 2025
6 checks passed
@TylerAdamMartinez TylerAdamMartinez deleted the ft-to-m-fix branch February 26, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants